GtkIconTheme: Be more careful when warning
authorMatthias Clasen <mclasen@redhat.com>
Mon, 23 Jun 2014 16:13:22 +0000 (12:13 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 23 Jun 2014 16:13:22 +0000 (12:13 -0400)
It sucks when printing a warning causes gnome-shell to crash,
so be more careful about icon names being NULL here.

gtk/gtkicontheme.c

index c3385e0f620a83fa5ae415fcf725802c56f8abf9..8a1f83568e3bc116d8232f341544b4cb1ba21641 100644 (file)
@@ -4208,12 +4208,12 @@ gtk_icon_info_load_symbolic_internal (GtkIconInfo    *icon_info,
       g_object_unref (pixbuf);
     }
 
-  if (icon_info->dir_type != ICON_THEME_DIR_SCALABLE)
-    g_warning ("Symbolic icon %s is not in a scalable icon theme directory",
-               icon_info->key.icon_names[0]);
+  if (icon_info->dir_type == ICON_THEME_DIR_UNTHEMED)
+    g_warning ("Symbolic icon %s is not in an icon theme directory",
+               icon_info->key.icon_names ? icon_info->key.icon_names[0] : icon_info->filename);
   else if (icon_info->dir_size * icon_info->dir_scale != icon_info->symbolic_size)
     g_warning ("Symbolic icon %s of size %d is in an icon theme directory of size %d",
-               icon_info->key.icon_names[0],
+               icon_info->key.icon_names ? icon_info->key.icon_names[0] : icon_info->filename,
                icon_info->symbolic_size,
                icon_info->dir_size * icon_info->dir_scale);